Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server_vllm.py #253

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Update server_vllm.py #253

merged 3 commits into from
Aug 22, 2024

Conversation

bet0x
Copy link
Contributor

@bet0x bet0x commented Aug 20, 2024

Hello,

There's an error occurring in the /v1/models endpoint of the API server. The error is happening because the served_model variable is a list instead of a string, which is causing validation errors when trying to create a ModelCard object.

bet0x and others added 2 commits August 20, 2024 12:47
Hello, 

There's an error occurring in the /v1/models endpoint of the API server. The error is happening because the served_model variable is a list instead of a string, which is causing validation errors when trying to create a ModelCard object.
@jeffreymeetkai
Copy link
Collaborator

Hi, thanks for the fix! I made some other changes too, mainly refactoring the served_model = [args.model] instead of using either args.served_model_name or args.model. We'll wait for #257 to be ready then I will merge this. 🚀

Copy link
Collaborator

@jeffreymeetkai jeffreymeetkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffreymeetkai jeffreymeetkai merged commit a3400cd into MeetKai:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants