configurable bucket versioning #22
Merged
+55
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
4c93fc0 to
4129f8f
Compare
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
4129f8f to
cac84a4
Compare
|
@jubrad shall we get that merged? There is a minor merge conflict but besides that I think that we are good to merge it and have it in the next release. |
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
3 times, most recently
from
5e04cad to
56cc638
Compare
kay-kim
approved these changes
Mar 28, 2025
README.md
Outdated
| @@ -76,6 +76,8 @@ No resources. | |||
| | <a name="input_region"></a> [region](#input\_region) | The region where resources will be created | `string` | `"us-central1"` | no | | |||
| | <a name="input_use_local_chart"></a> [use\_local\_chart](#input\_use\_local\_chart) | Whether to use a local chart instead of one from a repository | `bool` | `false` | no | | |||
| | <a name="input_use_self_signed_cluster_issuer"></a> [use\_self\_signed\_cluster\_issuer](#input\_use\_self\_signed\_cluster\_issuer) | Whether to install and use a self-signed ClusterIssuer for TLS. Due to limitations in Terraform, this may not be enabled before the cert-manager CRDs are installed. | `bool` | `false` | no | | |||
| | <a name="input_storage_bucket_versioning"></a> [use\_storage\_bucket\_versioning](#input\_use\_storage\_bucket\_versioning) | Enable bucket versioning (Disabled by default due to deletion timeouts). | `bool` | `false` | no | | |||
There was a problem hiding this comment.
? We probably should regenerate the readme.md using terraform-doc? since I think it's just storage_bucket_versioning and storage_bucket_version_ttl instead of use_storage ...
There was a problem hiding this comment.
Yeah, sorry I always forget about that.
README.md
Outdated
|
|
||
|
|
||
| #### Storage Bucket Versioning | ||
| By default storage bucket versinioning is turned off. This both reduces |
There was a problem hiding this comment.
Suggested change
| By default storage bucket versinioning is turned off. This both reduces | |
| By default, storage bucket versioning is turned off. This both reduces |
Also, added MaterializeInc/materialize#32041 to go with this change. I just used v0.2.1 as a placeholder ... but can change to whatever version.
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
56cc638 to
2e5e5e8
Compare
kay-kim
reviewed
Mar 28, 2025
modules/storage/variables.tf
Outdated
| @@ -50,3 +57,10 @@ variable "lifecycle_rules" { | |||
| } | |||
| ] | |||
| } | |||
|
|
|||
| variable "version_ttl" { | |||
| description = "Sets the TTL (in days) on non current sotarge bucket objects." | |||
variables.tf
Outdated
| } | ||
|
|
||
| variable "storage_bucket_version_ttl" { | ||
| description = "Sets the TTL (in days) on non current sotarge bucket objects." |
variables.tf
Outdated
| @@ -158,6 +158,18 @@ variable "install_metrics_server" { | |||
| default = false | |||
| } | |||
|
|
|||
| variable "storage_bucket_versioning" { | |||
| description = "Enable bucket versioning (Disabled by default due to deletion timeouts)." | |||
There was a problem hiding this comment.
Should this have "When enabled, set storage_bucket_version_ttl." or something?
There was a problem hiding this comment.
I've just set a default of 7 days for versioning.
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
2e5e5e8 to
c3ba56d
Compare
jubrad
changed the title
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
c3ba56d to
04d9bfa
Compare
jubrad
force-pushed
the
disable-bucket-versioning-by-default
branch
from
04d9bfa to
00f9cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help fix some deletion timeouts.
If you want to delete a bucket that has had versioning enabled the ideal way to do this is to set the
version_ttlto one day, then wait a day, then delete. Haven't tested whether setting it to 0 would work.