-
Notifications
You must be signed in to change notification settings - Fork 470
docs: google terraform storage bucket versioning #32041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: google terraform storage bucket versioning #32041
Conversation
@@ -4,17 +4,29 @@ columns: | |||
|
|||
rows: | |||
- "Terraform version": | | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
47336b7
to
1884b23
Compare
@@ -71,6 +71,13 @@ In addition, the default [`node_group_instance_types`] has changed from | |||
|
|||
{{</ tabs >}} | |||
|
|||
## Storage bucket versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1884b23
to
ee11eb7
Compare
ee11eb7
to
28b10fb
Compare
Starting in v0.2.1 of Materialize on GCP Terraform, storage bucket versioning is | ||
disabled to facilitate cleanup of resources during testing. When running in | ||
production, versioning should be turned on with a sufficient TTL to meet any | ||
data-recovery requirements. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the referenced pr I did decide to enable versioning with a TTL of 7 days for non active versions, but make this configurable. This is a middle ground that more easily allows one to test without versioning enabled while maintaining the preferred production setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will do a patch tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ... apparently, "tomorrow" is "next week" 😄 .
In any case, it's still disabled, yes? (I see the default is false
) it's just that the ttl default value is set to 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, sorry I think I waffled on this a few times thanks for reading closely!!!
28b10fb
to
ec6d628
Compare
614bc14
into
MaterializeInc:self-managed-docs/v25.1
reference docs update per MaterializeInc/terraform-google-materialize#22