Skip to content

docs: google terraform storage bucket versioning #32041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kay-kim
Copy link
Contributor

@kay-kim kay-kim commented Mar 28, 2025

@kay-kim kay-kim requested a review from a team as a code owner March 28, 2025 16:27
@kay-kim kay-kim requested a review from jubrad March 28, 2025 16:28
@@ -4,17 +4,29 @@ columns:

rows:
- "Terraform version": |


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kay-kim kay-kim force-pushed the docs-google-terraform-next branch from 47336b7 to 1884b23 Compare March 28, 2025 16:36
@@ -71,6 +71,13 @@ In addition, the default [`node_group_instance_types`] has changed from

{{</ tabs >}}

## Storage bucket versioning
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kay-kim kay-kim force-pushed the docs-google-terraform-next branch from 1884b23 to ee11eb7 Compare March 28, 2025 19:50
@kay-kim kay-kim marked this pull request as draft March 28, 2025 19:51
@kay-kim kay-kim force-pushed the docs-google-terraform-next branch from ee11eb7 to 28b10fb Compare March 31, 2025 21:35
Comment on lines 29 to 33
Starting in v0.2.1 of Materialize on GCP Terraform, storage bucket versioning is
disabled to facilitate cleanup of resources during testing. When running in
production, versioning should be turned on with a sufficient TTL to meet any
data-recovery requirements.

Copy link
Contributor

@jubrad jubrad Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the referenced pr I did decide to enable versioning with a TTL of 7 days for non active versions, but make this configurable. This is a middle ground that more easily allows one to test without versioning enabled while maintaining the preferred production setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will do a patch tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... apparently, "tomorrow" is "next week" 😄 .
In any case, it's still disabled, yes? (I see the default is false) it's just that the ttl default value is set to 7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, sorry I think I waffled on this a few times thanks for reading closely!!!

@kay-kim kay-kim force-pushed the docs-google-terraform-next branch from 28b10fb to ec6d628 Compare April 11, 2025 19:09
@kay-kim kay-kim marked this pull request as ready for review April 11, 2025 19:09
@kay-kim kay-kim requested a review from jubrad April 15, 2025 18:19
@kay-kim kay-kim merged commit 614bc14 into MaterializeInc:self-managed-docs/v25.1 Apr 16, 2025
8 checks passed
@kay-kim kay-kim deleted the docs-google-terraform-next branch April 16, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants