Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying listen args more than once #30928

Merged
merged 1 commit into from
Jan 2, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/environmentd/src/environmentd/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ pub struct Args {
long,
env = "SQL_LISTEN_ADDR",
value_name = "HOST:PORT",
default_value = "127.0.0.1:6875"
default_value = "127.0.0.1:6875",
action = ArgAction::Set,
)]
sql_listen_addr: SocketAddr,
/// The address on which to listen for untrusted HTTP connections.
Expand All @@ -122,7 +123,8 @@ pub struct Args {
long,
env = "HTTP_LISTEN_ADDR",
value_name = "HOST:PORT",
default_value = "127.0.0.1:6876"
default_value = "127.0.0.1:6876",
action = ArgAction::Set,
)]
http_listen_addr: SocketAddr,
/// The address on which to listen for trusted SQL connections.
Expand All @@ -135,7 +137,8 @@ pub struct Args {
long,
value_name = "HOST:PORT",
env = "INTERNAL_SQL_LISTEN_ADDR",
default_value = "127.0.0.1:6877"
default_value = "127.0.0.1:6877",
action = ArgAction::Set,
)]
internal_sql_listen_addr: SocketAddr,
/// The address on which to listen for trusted HTTP connections.
Expand All @@ -147,7 +150,8 @@ pub struct Args {
long,
value_name = "HOST:PORT",
env = "INTERNAL_HTTP_LISTEN_ADDR",
default_value = "127.0.0.1:6878"
default_value = "127.0.0.1:6878",
action = ArgAction::Set,
)]
internal_http_listen_addr: SocketAddr,
/// The address on which to listen for Persist PubSub connections.
Expand All @@ -159,7 +163,8 @@ pub struct Args {
long,
value_name = "HOST:PORT",
env = "INTERNAL_PERSIST_PUBSUB_LISTEN_ADDR",
default_value = "127.0.0.1:6879"
default_value = "127.0.0.1:6879",
action = ArgAction::Set,
)]
internal_persist_pubsub_listen_addr: SocketAddr,
/// Enable cross-origin resource sharing (CORS) for HTTP requests from the
Expand Down
Loading