Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying listen args more than once #30928

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

doy-materialize
Copy link
Contributor

Motivation

we provide defaults for these in the environmentd dockerfile entrypoint

another followup to #30895

not sure if there's a better fix for this?

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

we provide defaults for these in the environmentd dockerfile entrypoint
@alex-hunt-materialize alex-hunt-materialize merged commit ace7379 into main Jan 2, 2025
79 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the push-pqumsmkuyssq branch January 2, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants