Skip to content

Conversation

muskaan-mittal
Copy link
Contributor

No description provided.

@muskaan-mittal muskaan-mittal marked this pull request as ready for review October 19, 2025 19:36
# Node is publishing to the video_frames topic using the message type Image
self.pub = self.create_publisher(Image, '/zed2/zed_node/rgb/image_rect_color', qos_profile=10)
# Create a VideoCapture object
# The argument '0' gets the default webcam.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What line of code is this comment referring to?

# when I run this, this input is currently "not a numpy array"
# but we can think about the processing here once we actually have an image we wanna publish

#cap.set(cv2.CAP_PROP_EXPOSURE, -8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#cap.set(cv2.CAP_PROP_EXPOSURE, -8)

Copy link
Contributor

@alexanderbowler alexanderbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@muskaan-mittal muskaan-mittal merged commit 67563be into new_ml Oct 21, 2025
2 checks passed
@muskaan-mittal muskaan-mittal deleted the muskaan_png_pub branch October 21, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants