Skip to content

Conversation

gaoshenghan1130
Copy link

@gaoshenghan1130 gaoshenghan1130 commented Sep 14, 2025

  • Reconstruction of old teleop
  • not sure about the correctness of portation towards ros2
  • haven't been tested with a real controller

closes #88

muskaan note: we also have to make some functionality changes to this code. arnav was saying he had some in mind so we can ask him.

Copy link
Member

@HenryLeC HenryLeC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few ROS2 migration changes

@HenryLeC HenryLeC linked an issue Sep 15, 2025 that may be closed by this pull request
@HenryLeC HenryLeC removed a link to an issue Sep 15, 2025
Base automatically changed from ros2 to devel October 5, 2025 17:12
@RCoder01
Copy link
Member

RCoder01 commented Oct 5, 2025

@HenryLeC Should parameter loading use the ros2 parameters or is just python yaml loading sufficient?

@HenryLeC
Copy link
Member

HenryLeC commented Oct 5, 2025

@HenryLeC Should parameter loading use the ros2 parameters or is just python yaml loading sufficient?

For this it probably isn't needed to load parameters using ROS2 but in general it allows for changing them at runtime if thats every something we need (It probably won't be). Its also just a more uniform interface so that each node can use the same bad parameter implementation instead of creating its own.

ROS2 paramaters will also type check the yaml file and ensure all required params have values and switch the optional ones to their default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redo teleop

3 participants