-
Notifications
You must be signed in to change notification settings - Fork 3
port the new teleop to ros2 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few ROS2 migration changes
… .launch file Co-authored-by: Henry LeCompte <[email protected]>
…2_mrobosub_teleop
@HenryLeC Should parameter loading use the ros2 parameters or is just python yaml loading sufficient? |
For this it probably isn't needed to load parameters using ROS2 but in general it allows for changing them at runtime if thats every something we need (It probably won't be). Its also just a more uniform interface so that each node can use the same bad parameter implementation instead of creating its own. ROS2 paramaters will also type check the yaml file and ensure all required params have values and switch the optional ones to their default. |
closes #88
muskaan note: we also have to make some functionality changes to this code. arnav was saying he had some in mind so we can ask him.