Skip to content

fix(web): reserve macOS titlebar controls #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfiesch merged 3 commits into from
Jul 18, 2026
Merged

fix(web): reserve macOS titlebar controls #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e598a1
fix(web): reserve macOS titlebar controls
wolfiesch Jul 18, 2026
9cac60d
chore: refresh shell provenance checksum
wolfiesch Jul 18, 2026
1bc3d90
fix(web): scope titlebar inset to desktop
wolfiesch Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/web/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,13 @@
min-height: 2.75rem;
}
}
}

/* These platform reserves must share Tailwind's utilities layer. The
titlebar also uses px-* utilities, and a later cascade layer wins before
selector specificity is considered. Keeping these rules here ensures the
native window controls always take precedence over the normal padding. */
@layer utilities {
/* macOS traffic lights live at the top-left of the frameless window.
Reserve their inset; the desktop shell owns the real controls. */
[data-platform="darwin"] .titlebar-traffic-light-inset {
Comment thread
wolfiesch marked this conversation as resolved.
Outdated
Expand Down
10 changes: 10 additions & 0 deletions e2e/pwa-install.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ test.afterAll(async () => {
await web?.stop();
});

test("reserves the native macOS traffic-light area in the titlebar", async ({ page }) => {
await page.goto(`${web.url}fixture?platform=darwin&reset=1`, {
waitUntil: "domcontentloaded",
});

const titlebar = page.locator("header");
await expect(titlebar).toHaveCSS("padding-left", "76px");
await expect(titlebar.getByRole("button", { name: /session list/u })).toBeVisible();
});

test("installs from the hosted-client titlebar without overflowing a phone", async ({ page }) => {
await page.setViewportSize({ width: 320, height: 568 });
await page.goto(web.url, { waitUntil: "domcontentloaded" });
Expand Down
Loading