fix(web): reserve macOS titlebar controls - #45
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e598a113d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR fixes macOS titlebar layout by ensuring the “traffic-light” (window control) inset reservation is applied in Tailwind’s utilities cascade layer so it cannot be overridden by later padding utilities, and adds an end-to-end regression test to lock in the expected computed inset.
Changes:
- Move the macOS/Linux titlebar reserve rules into Tailwind’s
@layer utilitiesto ensure correct cascade precedence. - Add a Playwright regression test asserting the macOS titlebar computes to a 76px left padding inset in the fixture.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/pwa-install.spec.ts | Adds a regression test validating the computed macOS traffic-light inset and basic titlebar usability. |
| apps/web/src/app.css | Ensures platform-specific titlebar reserve styles live in Tailwind’s utilities layer so padding utilities can’t override them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Verification
pnpm checkpnpm testpnpm exec playwright test e2e/pwa-install.spec.ts