Skip to content

fix(web): reserve macOS titlebar controls - #45

Merged
wolfiesch merged 3 commits into
LycaonLLC:mainfrom
wolfiesch:codex/fix-macos-titlebar-controls
Jul 18, 2026
Merged

fix(web): reserve macOS titlebar controls#45
wolfiesch merged 3 commits into
LycaonLLC:mainfrom
wolfiesch:codex/fix-macos-titlebar-controls

Conversation

@wolfiesch

Copy link
Copy Markdown
Collaborator

Summary

  • keep the macOS traffic-light reserve in Tailwind’s utility layer so normal titlebar padding cannot override it
  • add a browser regression test for the computed 76px inset

Verification

  • pnpm check
  • pnpm test
  • pnpm exec playwright test e2e/pwa-install.spec.ts
  • real macOS Electron window visual check

Copilot AI review requested due to automatic review settings July 18, 2026 11:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e598a113d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/app.css Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes macOS titlebar layout by ensuring the “traffic-light” (window control) inset reservation is applied in Tailwind’s utilities cascade layer so it cannot be overridden by later padding utilities, and adds an end-to-end regression test to lock in the expected computed inset.

Changes:

  • Move the macOS/Linux titlebar reserve rules into Tailwind’s @layer utilities to ensure correct cascade precedence.
  • Add a Playwright regression test asserting the macOS titlebar computes to a 76px left padding inset in the fixture.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
e2e/pwa-install.spec.ts Adds a regression test validating the computed macOS traffic-light inset and basic titlebar usability.
apps/web/src/app.css Ensures platform-specific titlebar reserve styles live in Tailwind’s utilities layer so padding utilities can’t override them.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wolfiesch
wolfiesch merged commit f7e981f into LycaonLLC:main Jul 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants