Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor methods in Dx12ResourceDataUtil #1426

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

davidd-lunarg
Copy link
Contributor

@davidd-lunarg davidd-lunarg commented Feb 19, 2024

Refactor common code for reading or writing resource data into static
functions. The existing functions work the same. The new functions can
be used to allow more control for reading and writing resources.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 135923.

Copy link
Contributor

@locke-lunarg locke-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidd-lunarg davidd-lunarg force-pushed the davidd-refactor-res-util branch from 46a782f to fe76bf4 Compare February 19, 2024 22:12
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 136015.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3745 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3745 failed.

@davidd-lunarg davidd-lunarg force-pushed the davidd-refactor-res-util branch from fe76bf4 to 2b05d09 Compare February 20, 2024 18:37
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 136653.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 136653 cancelled.

Refactor common code for reading or writing resource data into static
functions. The existing functions work the same. The new functions can
be used to allow more control for reading and writing resources.
@davidd-lunarg davidd-lunarg force-pushed the davidd-refactor-res-util branch from 2b05d09 to ab093c6 Compare February 20, 2024 20:22
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 136766.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3749 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build queued with queue ID 136982.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 317 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3749 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct-extended build # 317 passed.

@davidd-lunarg davidd-lunarg merged commit cec58f6 into LunarG:dev Feb 22, 2024
8 checks passed
@davidd-lunarg davidd-lunarg deleted the davidd-refactor-res-util branch February 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants