Refactor methods in Dx12ResourceDataUtil

Refactor common code for reading or writing resource data into static functions. The existing functions work the same. The new functions can be used to allow more control for reading and writing resources.
LunarG · Feb 19, 2024 · fe76bf4 · fe76bf4
1 parent fc05196
commit fe76bf4
Show file tree

Hide file tree

Showing 4 changed files with 305 additions and 239 deletions.
diff --git a/framework/decode/dx12_replay_consumer_base.cpp b/framework/decode/dx12_replay_consumer_base.cpp
@@ -354,8 +354,7 @@ void Dx12ReplayConsumerBase::ApplyBatchedResourceInitInfo(
                                                      resource_info.second.data,
                                                      resource_info.second.subresource_offsets,
                                                      resource_info.second.subresource_sizes,
-                                                     resource_info.second.staging_resource,
-                                                     true);
+                                                     resource_info.second.staging_resource);
             }
         }
         resource_data_util_->CloseCommandList();

diff --git a/framework/decode/dx12_resource_value_mapper.cpp b/framework/decode/dx12_resource_value_mapper.cpp
@@ -1333,8 +1333,8 @@ void Dx12ResourceValueMapper::MapResources(const ResourceValueInfoMap&
                                                            temp_resource_states,
                                                            temp_resource_states,
                                                            temp_resource_data,
-                                                           temp_resource_sizes,
-                                                           temp_resource_offsets);
+                                                           temp_resource_offsets,
+                                                           temp_resource_sizes);
 
         if (SUCCEEDED(hr))
         {
@@ -1367,8 +1367,8 @@ void Dx12ResourceValueMapper::MapResources(const ResourceValueInfoMap&
                                                           temp_resource_states,
                                                           temp_resource_states,
                                                           temp_resource_data,
-                                                          temp_resource_sizes,
-                                                          temp_resource_offsets);
+                                                          temp_resource_offsets,
+                                                          temp_resource_sizes);
             }
 
             if (FAILED(hr))