-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile guide for Fabric #19330
Compile guide for Fabric #19330
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
5685611 | Triggered | Generic High Entropy Secret | a0f4144 | tests/tests_data/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | a0f4144 | tests/tests_data/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | a0f4144 | tests/tests_data/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | a0f4144 | tests/tests_data/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
4770540
to
9fc6312
Compare
⚡ Required checks status: All passing 🟢Groups summary🟢 fabric: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
# Compile the model | ||
model = torch.compile(model) | ||
|
||
# Default: `fabric.setup()` will not reapply the compilation over DDP/FSDP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL. I thought we were doing this by default already. What's blocking us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are usually quite sensitive with breaking changes, I wanted to make this experimental first for one release. I still need to do the work and run a batch of lit-gpt models with this settings to be sure this is not counter productive as a default. But happy to discuss this further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect any significant number of users to find and enable this private flag. If you are afraid because the release is close, that's fine. But I would enable it as soon as we can after so that at least nightly users try it out
What does this PR do?
Part of #18852
Adds a guide for speeding up models with
torch.compile
and advice in combination with Fabric.📚 Documentation preview 📚: https://pytorch-lightning--19330.org.readthedocs.build/en/19330/
cc @Borda @carmocca @justusschock @awaelchli