Skip to content

Compile guide for Trainer #19531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 28, 2024
Merged

Compile guide for Trainer #19531

merged 10 commits into from
Feb 28, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 26, 2024 •
edited by github-actions bot
Loading

What does this PR do?

Adds a similar guide to PyTorch Lightning as done in #19330 for Fabric.

Fixes #18852

📚 Documentation preview 📚: https://pytorch-lightning--19531.org.readthedocs.build/en/19531/

cc @Borda @carmocca

@awaelchli awaelchli added docs Documentation related fun Staff contributions outside working hours - to differentiate from the "community" label labels Feb 26, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 26, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 26, 2024
@awaelchli awaelchli added torch.compile and removed pl Generic label for PyTorch Lightning package labels Feb 26, 2024
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 26, 2024
@gitguardian GitGuardian

This comment was marked as spam.

Sign in to view
@awaelchli awaelchli marked this pull request as ready for review February 27, 2024 03:42
@awaelchli awaelchli requested a review from carmocca February 27, 2024 03:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to docs/source-fabric/advanced/compile.rst.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to docs/source-pytorch/advanced/compile.rst, docs/source-pytorch/advanced/speed.rst, docs/source-pytorch/glossary/index.rst, docs/source-pytorch/levels/intermediate.rst, docs/source-pytorch/levels/intermediate_level_13.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 27, 2024
lantiga
lantiga approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few changes

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 28, 2024
@awaelchli awaelchli merged commit 48c39ce into master Feb 28, 2024
@awaelchli awaelchli deleted the docs/compile branch February 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga lantiga approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

+1 more reviewer

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged torch.compile

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

Add torch.compile guide to docs

4 participants

@awaelchli @lantiga @Borda @carmocca