Skip to content

Translate shape for fd.ops.full #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+23 −1
Open

Translate shape for fd.ops.full #2763

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89ffa4e
Translate shape for fd.ops.full
shino16 Nov 20, 2025
63c662e
Empty commit; why did the CI shut down?
shino16 Nov 20, 2025
02dbbef
Add test
shino16 Nov 21, 2025
9867c12
Add comment
shino16 Nov 21, 2025
477e631
Merge branch 'main' into nvfuser-translate-shape
shino16 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion thunder/executors/nvfuserex_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,12 +1043,13 @@ def full(
fd: FusionDefinition,
lc_to_nv_map: dict,
) -> Any:
nv_shape = getnv(shape, fd, lc_to_nv_map, inline_number=True)
Copy link
Collaborator Author

@shino16 shino16 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my interpretation, we put inline_number=True simply because we don't want to create fd.define_scalar for each dimension every time.

nv_fill_value = getnv(fill_value, fd, lc_to_nv_map)
nvdtype = lcdtype_to_nvdtype(dtype)

_select_device(fd, device)

return fd.ops.full(shape, nv_fill_value, nvdtype)
return fd.ops.full(nv_shape, nv_fill_value, nvdtype)


register_supported(PrimIDs.FULL, full, _full_check)
Expand Down
Loading