Translate shape for fd.ops.full #2763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: crcrpar <[email protected]>
shino16
commented
Nov 20, 2025
| fd: FusionDefinition, | ||
| lc_to_nv_map: dict, | ||
| ) -> Any: | ||
| nv_shape = getnv(shape, fd, lc_to_nv_map, inline_number=True) |
Collaborator
Author
There was a problem hiding this comment.
In my interpretation, we put inline_number=True simply because we don't want to create fd.define_scalar for each dimension every time.
crcrpar
approved these changes
Nov 21, 2025
Collaborator
crcrpar
left a comment
crcrpar
left a comment
There was a problem hiding this comment.
can we have a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #2677. As explained in #2677 (comment), this patch fixes an error which is caused by feeding a
NumberProxyfor shape directly intofd.ops.full.