Skip to content

Fixissue876 - #931

Merged
ogazboiz merged 4 commits into
LabsCrypt:mainfrom
razeprasine:Fixissue876
Jun 29, 2026
Merged

Fixissue876#931
ogazboiz merged 4 commits into
LabsCrypt:mainfrom
razeprasine:Fixissue876

Conversation

@razeprasine

Copy link
Copy Markdown
Contributor

Description

Skeleton loading placeholders were implemented three inconsistent ways across the codebase:

  • ui/Skeleton.tsx used animate-pulse bg-gray-200 dark:bg-gray-700
  • dashboard/dashboard-view.tsx had a custom SkeletonCard with a CSS shimmer animation (animate-[shimmer_1.4s_infinite]) and bg-white/5
  • wallet/WalletButton.tsx used a dedicated .wallet-btn-skeleton CSS class
  • Additionally, StreamListSkeleton was exported from Skeleton.tsx but never imported anywhere

Type of Change

  • 🔧 Refactoring (no functional changes)

Related Issues

Closes #876

Changes Made

  • ui/Skeleton.tsx: Removed dead StreamListSkeleton export (unreferenced in any component)
  • dashboard/dashboard-view.tsx: Replaced custom SkeletonCard shimmer implementation with the shared Skeleton component. Added import from @/components/ui/Skeleton
  • wallet/WalletButton.tsx: Replaced wallet-btn-skeleton CSS class with shared <Skeleton className="w-[140px] h-[2.4rem] rounded-full" />. Added import from @/components/ui/Skeleton

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

  1. Load the dashboard — verify loading skeleton cards use the consistent animate-pulse animation and gray color scheme
  2. Load the wallet button while unhydrated — verify the placeholder uses the same skeleton styling
  3. Navigate to /incoming — verify skeleton cards are visually consistent with dashboard skeletons

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

No breaking changes. The .wallet-btn-skeleton CSS class in globals.css remains as dead CSS (out of scope for this change). The incoming page's LoadingCard already used the shared Skeleton component and required no changes.

@ogazboiz
ogazboiz merged commit bb62c94 into LabsCrypt:main Jun 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Three divergent skeleton implementations; shared ui/Skeleton.StreamListSkeleton is dead code

2 participants