Skip to content

[Frontend] Three divergent skeleton implementations; shared ui/Skeleton.StreamListSkeleton is dead code #876

Description

@grantfox-oss

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

Skeleton placeholders are implemented three inconsistent ways: ui/Skeleton.tsx uses animate-pulse bg-gray-200, the dashboard reimplements its own SkeletonCard with bg-white/5 + shimmer, and the wallet button uses a CSS .wallet-btn-skeleton. The exported StreamListSkeleton (ui/Skeleton.tsx:11) is never imported anywhere.

Acceptance criteria

  • Standardize on one Skeleton primitive and have dashboard/wallet/incoming reuse it
  • Remove or wire up the unused StreamListSkeleton
  • Verify loading states look visually consistent across /dashboard, /incoming and the wallet button

Files to touch

  • frontend/src/components/ui/Skeleton.tsx
  • frontend/src/components/dashboard/dashboard-view.tsx
  • frontend/src/components/wallet/WalletButton.tsx

Out of scope

  • Changing when skeletons are shown

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or requestfrontendFrontend related tasksuiUser interface refinement

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions