Skip to content

Excessive Data Creation Fix #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cameronbowe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Excessive Data Creation Fix #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e666e8a
A few things which prevent saving an abnormal amount of data especial…
github-actions[bot] Nov 10, 2025
3d01962
Handling the previous commit better.
github-actions[bot] Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions common/src/main/java/com/loohp/imageframe/objectholders/IFPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@
import java.io.PrintWriter;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;

public class IFPlayer {
Expand Down Expand Up @@ -105,8 +102,10 @@ public void save() throws Exception {
JsonObject preferenceJson = new JsonObject();
for (Map.Entry<IFPlayerPreference<?>, Object> entry : preferences.entrySet()) {
IFPlayerPreference<?> preference = entry.getKey();
preferenceJson.add(preference.getJsonName(), preference.getSerializer(Object.class).apply(entry.getValue()));
final Object value = entry.getValue();
if (!Objects.equals(value, preference.getDefaultValue(this))) preferenceJson.add(preference.getJsonName(), preference.getSerializer(Object.class).apply(value));
}
if (preferenceJson.size() == 0) return;
json.add("preferences", preferenceJson);
try (PrintWriter pw = new PrintWriter(new OutputStreamWriter(Files.newOutputStream(file.toPath()), StandardCharsets.UTF_8))) {
pw.println(GSON.toJson(json));
Expand Down