Excessive Data Creation Fix #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly at a large scale. When we save data, the following checks are now made. - A count is stored of how many properties are saved which are not default value. - It will not save a property if it's default value. - If all properties are default value, it will not save the player entirely.
Owner
|
Thank you for the PR! I was holding off on merging this because I was added DB support around the same time as your PR. Now that that is merged I can revisit your PR. I will take a look at this after the 1.21.11 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, hope all is well.
On our network, we noticed over 150,000 files within this plugin folder purely having the same default values. With this, I've created a patch that is aimed at eliminating this amount of data (especially at large scales).
Preventing this is quite simple. When serializing the properties, compare each value to the default- if it's the same, there is no reason to store it. After doing so, check the JSON array of serialized properties, and if it's empty, there is no reason to store the player's data entirely. This HEAVILY reduces the amount of data stored.
I'd love for you to look this over, and I appreciate your time.