feat(konnect): add support for basic auth credentials for consumers #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
credentials-basic-auth-konnect
branch
2 times, most recently
from
152a936 to
3d6ea2e
Compare
pmalek
force-pushed
the
credentials-basic-auth-konnect
branch
2 times, most recently
from
c68b5ba to
a85b542
Compare
czeslavo
reviewed
Sep 19, 2024
pmalek
force-pushed
the
credentials-basic-auth-konnect
branch
from
6e78a81 to
3489f1d
Compare
Co-authored-by: Grzegorz Burzyński <[email protected]>
czeslavo
reviewed
Sep 20, 2024
pmalek
force-pushed
the
credentials-basic-auth-konnect
branch
from
3489f1d to
4ce45b5
Compare
czeslavo
reviewed
Sep 20, 2024
Co-authored-by: Grzegorz Burzyński <[email protected]>
czeslavo
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a first reconciler and scaffolding around it for consumer credentials.
Initial support comes with basic auth credentials.
Related k-cfg PR: Kong/kubernetes-configuration#83
Blocked until above gets merged.Which issue this PR fixes
Fixes #617
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes