Skip to content

Commit 6e78a81

Browse files
pmalekczeslavo
andauthored
Apply suggestions from code review
Co-authored-by: Grzegorz Burzyński <[email protected]>
1 parent a85b542 commit 6e78a81

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
the creation of a managed `KongPluginBinding` resource, which is taken by the
7171
`KongPluginBinding` reconciler to create the corresponding plugin object in Konnect.
7272
[#550](https://github.com/Kong/gateway-operator/pull/550)
73-
- Add support for `KognConsumer` credentials:
73+
- Add support for `KongConsumer` credentials:
7474
- basic-auth [#625](https://github.com/Kong/gateway-operator/pull/625)
7575

7676
### Fixed

controller/konnect/ops/ops_credentialbasicauth.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ func createCredentialBasicAuth(
7171
return nil
7272
}
7373

74-
// updateRoute updates the Konnect Route entity.
75-
// It is assumed that provided KongRoute has Konnect ID set in status.
76-
// It returns an error if the KongRoute does not have a ControlPlaneRef or
74+
// updateCredentialBasicAuth updates the Konnect BasicAuth entity.
75+
// It is assumed that the provided BasicAuth has Konnect ID set in status.
76+
// It returns an error if the BasicAuth does not have a ControlPlaneRef or
7777
// if the operation fails.
7878
func updateCredentialBasicAuth(
7979
ctx context.Context,
@@ -123,8 +123,8 @@ func updateCredentialBasicAuth(
123123
return nil
124124
}
125125

126-
// deleteRoute deletes a KongRoute in Konnect.
127-
// It is assumed that provided KongRoute has Konnect ID set in status.
126+
// deleteCredentialBasicAuth deletes a BasicAuth credential in Konnect.
127+
// It is assumed that the provided BasicAuth has Konnect ID set in status.
128128
// It returns an error if the operation fails.
129129
func deleteCredentialBasicAuth(
130130
ctx context.Context,

0 commit comments

Comments
 (0)