Skip to content

fix: 계약 목록 - 계약 카테고리 null 값 안보이도록 수정 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julia98percent merged 2 commits into from
May 15, 2025
Merged

fix: 계약 목록 - 계약 카테고리 null 값 안보이도록 수정 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f305489
fix: 최근 계약 목록에서 매물 카테고리가 null이면 `-`로 보여주도록 수정
julia98percent May 15, 2025
5a12ee2
계약 수정 페이지 확인 버튼 오른쪽으로 이동
julia98percent May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/pages/ContractListPage/ContractAddButtonList/ContractEditModal/ContractEditModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,11 +605,17 @@ const ContractEditModal = ({
})}
</Box>
)}
<Button
text="수정"
onClick={handleSubmit}
sx={{ mt: 2, color: "white !important", backgroundColor: "#164F9E" }}
/>
<Box sx={{ display: "flex", justifyContent: "flex-end" }}>
<Button
text="수정"
onClick={handleSubmit}
sx={{
mt: 2,
color: "white !important",
backgroundColor: "#164F9E",
}}
Comment on lines +612 to +616
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting the Button's sx styling into a shared style constant if it will be reused elsewhere in the codebase to improve maintainability.

Suggested change
sx={{
mt: 2,
color: "white !important",
backgroundColor: "#164F9E",
}}
sx={editButtonStyles}

Copilot uses AI. Check for mistakes.
/>
</Box>
</Box>
</Modal>
);
Expand Down
11 changes: 6 additions & 5 deletions src/pages/DashboardPage/RecentContractsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,14 @@ const RecentContractsModal = ({
DEPOSIT: "#2196f3",
MONTHLY: "#ff9800",
};
if (!contract.category) return "-";
if (
!contract.category ||
!categoryKoreanMap[contract.category]
)
return "-";
return (
<Chip
label={
categoryKoreanMap[contract.category] ??
contract.category
}
label={categoryKoreanMap[contract.category]}
variant="outlined"
sx={{
color: colorMap[contract.category],
Expand Down