Skip to content

fix: 계약 목록 - 계약 카테고리 null 값 안보이도록 수정#177

Merged
julia98percent merged 2 commits intodevfrom
feature/176
May 15, 2025
Merged

fix: 계약 목록 - 계약 카테고리 null 값 안보이도록 수정#177
julia98percent merged 2 commits intodevfrom
feature/176

Conversation

@julia98percent
Copy link
Collaborator

#️⃣연관된 이슈

#176

📝작업 내용

이번 PR에서 작업한 내용을 간단하게 작성해주세요. 어떻게보다 무엇을 왜 수정했는지 설명해주세요. (이미지 첨부 가능)

📸 스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kernel360-kdev-4-zipline-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 4:37pm

@julia98percent julia98percent changed the title Feature/176 fix: 계약 목록 - 계약 카테고리 null 값 안보이도록 수정 May 15, 2025
@julia98percent julia98percent self-assigned this May 15, 2025
@julia98percent julia98percent added the 🛠️ Fix 버그 수정 label May 15, 2025
@julia98percent julia98percent requested a review from Copilot May 15, 2025 16:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue of displaying null values for contract categories by ensuring that contracts without a corresponding Korean label in the mapping are shown with a "-" label. It also refactors the inline sx styling for a Button component in the ContractEditModal for clearer formatting and alignment.

  • Updated condition in RecentContractsModal to hide contract categories when no valid mapping exists.
  • Reformatted sx styling and added a flex container in ContractEditModal to align the submit Button to the right.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/pages/DashboardPage/RecentContractsModal.tsx Enhanced the check for contract.category to prevent rendering null values by verifying existence in the categoryKoreanMap.
src/pages/ContractListPage/ContractAddButtonList/ContractEditModal/ContractEditModal.tsx Reformatted the inline sx styling for the submit Button and added a flex container for proper alignment.
Comments suppressed due to low confidence (1)

src/pages/DashboardPage/RecentContractsModal.tsx:199

  • The updated condition now returns '-' if there's no corresponding Korean label. Please ensure this change is thoroughly tested to confirm that no valid category label is inadvertently omitted.
if (!contract.category || !categoryKoreanMap[contract.category])

Comment on lines +612 to +616
sx={{
mt: 2,
color: "white !important",
backgroundColor: "#164F9E",
}}
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting the Button's sx styling into a shared style constant if it will be reused elsewhere in the codebase to improve maintainability.

Suggested change
sx={{
mt: 2,
color: "white !important",
backgroundColor: "#164F9E",
}}
sx={editButtonStyles}

Copilot uses AI. Check for mistakes.
@julia98percent julia98percent merged commit 3b7128e into dev May 15, 2025
3 checks passed
@julia98percent julia98percent deleted the feature/176 branch May 15, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠️ Fix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants