-
Notifications
You must be signed in to change notification settings - Fork 5
refactor:: yunNote 반영 리팩토링 #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package com.kernel360.main.controller; | ||
| package com.kernel360.main.enumset; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. enum 타입 패키지 이동 후 메서드 public 부여 확인 했습니다. |
||
|
|
||
| import com.kernel360.product.dto.ProductResponse; | ||
| import com.kernel360.product.dto.ProductSearchDto; | ||
|
|
@@ -10,7 +10,7 @@ public enum Sort { | |
|
|
||
| VIEW_COUNT_PRODUCT_ORDER("viewCnt-order") { | ||
| @Override | ||
| Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
| public Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
|
|
||
| return productService.getProductListOrderByViewCount(pageable); | ||
| } | ||
|
|
@@ -25,7 +25,7 @@ public Page<ProductResponse> withKeywordSort(ProductService productService, Stri | |
|
|
||
| VIOLATION_PRODUCT_LIST("violation-products") { | ||
| @Override | ||
| Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
| public Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
|
|
||
| return productService.getViolationProducts(pageable); | ||
| } | ||
|
|
@@ -39,7 +39,7 @@ public Page<ProductResponse> withKeywordSort(ProductService productService, Stri | |
|
|
||
| RECOMMENDATION_PRODUCT_ORDER("recommend-order") { | ||
| @Override | ||
| Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
| public Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
|
|
||
| return productService.getFavoriteProducts(pageable); | ||
| } | ||
|
|
@@ -53,7 +53,7 @@ public Page<ProductResponse> withKeywordSort(ProductService productService, Stri | |
|
|
||
| RECENT_PRODUCT_ORDER("recent-order") { | ||
| @Override | ||
| Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
| public Page<ProductResponse> sort(ProductService productService, Pageable pageable) { | ||
|
|
||
| return productService.getRecentProducts(pageable); | ||
| } | ||
|
|
@@ -75,7 +75,7 @@ public String getOrderType() { | |
| return orderType; | ||
| } | ||
|
|
||
| abstract Page<ProductResponse> sort(ProductService productService, Pageable pageable); | ||
| public abstract Page<ProductResponse> sort(ProductService productService, Pageable pageable); | ||
|
|
||
| public abstract Page<ProductResponse> withKeywordSort(ProductService productService, String keyword, Pageable pageable); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,13 @@ | ||
| package com.kernel360.member.dto; | ||
|
|
||
| import jakarta.validation.constraints.NotBlank; | ||
| import jakarta.validation.constraints.Pattern; | ||
| import jakarta.validation.constraints.Size; | ||
|
|
||
| public record PasswordDto( | ||
| @NotBlank(message = "비밀번호는 비어 있을수 없습니다.") | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이건 저희 로그상에서만 확인 가능한 메세지를 내보내주는 역할인가 보네요 |
||
| @Size(min = 8, max = 16, message = "비밀번호는 8~16글자입니다.") | ||
| @Pattern(regexp = "^(?=.*\\d)(?=.*[a-zA-Z])(?=.*\\W).{8,16}$", message = "8~16자의 영문자(대/소문자 구분 없음), 숫자, 특수문자를 사용해 주세요.") | ||
| String password | ||
| ) { | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,8 @@ spring: | |
| format_sql: true | ||
| dialect: org.hibernate.dialect.PostgreSQLDialect | ||
| ddl-auto: validate | ||
| naming: | ||
| physical-strategy: org.hibernate.boot.model.naming.PhysicalNamingStrategyStandardImpl | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @column 애노테이션 제거 후 자동 매핑 처리를 위한 옵션 확인 했습니다. |
||
| flyway: | ||
| enabled: true | ||
| baseline-on-migrate: true | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package com.kernel360.product.entity; | ||
| package com.kernel360.product.enumset; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hibernate 가 자동으로 이름 붙여주는 부분 확인하였습니다