refactor:: yunNote 반영 리팩토링#276
Merged
HyunJunSon merged 2 commits intoKernel360:developfrom Mar 7, 2024
Merged
Conversation
HyunJunSon
requested review from
chan99k,
gunsight1 and
linglong67
as code owners
gunsight1
approved these changes
Mar 6, 2024
| @@ -1,4 +1,4 @@ | |||
| package com.kernel360.main.controller; | |||
| package com.kernel360.main.enumset; | |||
Collaborator
There was a problem hiding this comment.
enum 타입 패키지 이동 후 메서드 public 부여 확인 했습니다.
| import jakarta.validation.constraints.Size; | ||
|
|
||
| public record PasswordDto( | ||
| @NotBlank(message = "비밀번호는 비어 있을수 없습니다.") |
Collaborator
There was a problem hiding this comment.
이건 저희 로그상에서만 확인 가능한 메세지를 내보내주는 역할인가 보네요
| dialect: org.hibernate.dialect.PostgreSQLDialect | ||
| ddl-auto: validate | ||
| naming: | ||
| physical-strategy: org.hibernate.boot.model.naming.PhysicalNamingStrategyStandardImpl |
chan99k
approved these changes
Mar 7, 2024
| format_sql: true | ||
| dialect: org.hibernate.dialect.PostgreSQLDialect | ||
| ddl-auto: validate | ||
| naming: |
Collaborator
There was a problem hiding this comment.
hibernate 가 자동으로 이름 붙여주는 부분 확인하였습니다
| public record PasswordDto( | ||
| @NotBlank(message = "비밀번호는 비어 있을수 없습니다.") | ||
| @Size(min = 8, max = 16, message = "비밀번호는 8~16글자입니다.") | ||
| @Pattern(regexp = "^(?=.*[0-9])(?=.*[a-zA-Z])(?=\\S+$).{8,20}$", message = "8~16자의 영문 대/소문자, 숫자, 특수문자를 사용해 주세요.") |
linglong67
approved these changes
Mar 7, 2024
Collaborator
linglong67
left a comment
linglong67
left a comment
There was a problem hiding this comment.
확인했습니다~!
확인 요청드린 코멘트만 봐주세요~
Comment on lines
+9
to
+11
| @Size(min = 8, max = 16, message = "비밀번호는 8~16글자입니다.") | ||
| @Pattern(regexp = "^(?=.*[0-9])(?=.*[a-zA-Z])(?=\\S+$).{8,20}$", message = "8~16자의 영문 대/소문자, 숫자, 특수문자를 사용해 주세요.") | ||
| // @Pattern(regexp = "^(?=.*[0-9])(?=.*[a-zA-Z])(?=.*\\W).{8,16}$", message = "8~16자의 영문자(대/소문자 구분 없음), 숫자, 특수문자를 사용해 주세요.") |
Collaborator
There was a problem hiding this comment.
Size에 대한 내용과 대소문자 구분을 보면 아래 주석을 한 부분의 패턴이 맞는 것 같은데 아래 패턴을 주석처리하고 위 패턴으로 적용하신 이유가 있으실까요?
Collaborator
There was a problem hiding this comment.
깔끔해지겠군요 ㅎㅎ
저도 이후에 만드는 건 일단 이렇게 해봐야겠어요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
여기에 왜 이 PR이 필요했는지, PR을 통해 무엇이 바뀌는지에 대해서 설명해 주세요는 carInfo, washInfo entity 대상으로 테스트 삼아 바꾸어보았습니다. 데이터베이스 반영은 잘되는 것을 확인했습니다.
다른 entity 적용여부는 얘기를 해보시면 좋을 듯 합니다.
🔨 Modified
🌟 More
📋 커밋 전 체크리스트
🤟🏻 PR로 완료된 이슈
closes #270