Skip to content

add error handling to ConnectedPhysicalDeviceManager::RefreshConnectedSDLGamepads #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briaguya0 merged 8 commits into from
Jan 9, 2026
Merged

add error handling to ConnectedPhysicalDeviceManager::RefreshConnectedSDLGamepads #973

briaguya0 merged 8 commits into from
Jan 9, 2026

Conversation

@Spodi
Copy link
Contributor

@Spodi Spodi commented Dec 31, 2025 •
edited
Loading

  • Fixes crash when SDL_GameControllerName returns NULL #976
  • Uses the GUID as name instead, if that is the case:
    531769358-fa077d06-701a-4cce-895c-48ce356790d9
  • Adds error checking at multiple points of failure and skips the device if any of them occur, because it's most likely unusable in those cases.
  • Add logging for the errors catched above

LUS bump PRs for ports:

github-actions[bot]
github-actions bot previously requested changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@Spodi
Copy link
Contributor Author

Spodi commented Jan 2, 2026

Urg, that's what I get for trying to fix formatting on my phone. Lol.

@Spodi Spodi force-pushed the fix-SDL_GameControllerName-NULL branch from 1bc6ac8 to 039d543 Compare January 2, 2026 15:29
@github-actions github-actions bot dismissed their stale review January 2, 2026 15:31

No Clang-Tidy warnings found so I assume my comments were addressed

Spodi added 3 commits January 5, 2026 00:35
@Spodi
Set name to GUID when empty
cf709d3 
00000000000000000000000000000000 should be displayed if the GUID is invalid as well.
@Spodi
fix typo
0eea898
@Spodi
Skip devices with a zeroed out GUID
e45e842 
This likely happens due to an invalid index, so the device is most likely invalid anyway.
github-actions[bot]
github-actions bot previously requested changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@Spodi @github-actions
Apply suggestions from tidy
ef8b948 
Sometimes I wish, I never fixed this thing :D

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review January 5, 2026 12:12

No Clang-Tidy warnings found so I assume my comments were addressed

@briaguya0 briaguya0 changed the title Fix crash when SDL_GameControllerName returns NULL add error handling to ConnectedPhysicalDeviceManager::RefreshConnectedSDLGamepads Jan 5, 2026
@Spodi Spodi mentioned this pull request Jan 8, 2026
Open
@briaguya0 briaguya0 merged commit e288c95 into Kenix3:main Jan 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briaguya0 briaguya0 briaguya0 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash when SDL_GameControllerName returns NULL

2 participants

@Spodi @briaguya0