Repository navigation
feat: add native Dock Doctor USB diagnostics - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Dock Doctor, a native Omarchy window for USB topology, observed connection history, and comparisons against a saved working baseline. Device selection, tree/list views, event filters, baseline replacement confirmation, local report export, and isolated illustrative mode are functional. USB discovery never changes hardware.
Proof
Narrow window capture
The screenshot is explicitly illustrative. Live startup reads sysfs. A separate remote read-only scan detected three USB nodes (two root controllers and one peripheral).
Fail-first probes reproduced empty retained-state acceptance, transient write failures, growing error text, misleading protocol diagnostics, stale live messages after demo/reconnection, and zero-width popup items. The final regression suite passes.
Gates
0c8de024fe0f964ce0e7b78f7269013f3a17a306: all registered gates passed from an isolated OptiPlex worktree.Review rounds
The permitted substitute replaced an original seat that produced no verdict on retry. Round 2 was superseded after a native shutdown regression exposed an event-monitor leak. That leak, both accepted follow-up findings, and the earlier accepted findings are fixed. Both completed final reviewers returned 5/5 with no findings. Missing primary verdicts are explicitly recorded and are not counted as passes. Rejected findings concerned an unsupported Windows runtime and a percent-sign path scenario disproved by a remote Qt probe.
Needs a human
factory: rounds=3 evidence=A,B,D host=optiplex