Skip to content

Don't leak mosquitto headers #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't leak mosquitto headers #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/KDMqtt/mqtt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
Contact KDAB at <[email protected]> for commercial licensing options.
*/
#include "mqtt.h"
#include "mosquitto_wrapper.h"
#include <memory>
#include <spdlog/spdlog.h>

Expand Down
5 changes: 4 additions & 1 deletion src/KDMqtt/mqtt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include <KDFoundation/file_descriptor_notifier.h>
#include <KDFoundation/timer.h>
#include <KDMqtt/kdmqtt_global.h>
#include <KDMqtt/mosquitto_wrapper.h>
#include <KDUtils/bytearray.h>
#include <KDUtils/file.h>
#include <KDUtils/flags.h>
Expand All @@ -28,12 +27,16 @@
using namespace KDFoundation;
using namespace KDUtils;

struct mosquitto_message;

namespace KDMqtt {

constexpr int c_defaultPort = 1883;
constexpr std::chrono::duration c_defaultKeepAlive = std::chrono::minutes(1);

class IMqttClient;
class MosquittoLib;
class MosquittoClient;

/*
* Class: IMqttManager
Expand Down
3 changes: 2 additions & 1 deletion tests/auto/mqtt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ add_executable(

target_include_directories(
${PROJECT_NAME}
PRIVATE ${CMAKE_SOURCE_DIR}/tests/auto/foundation/common ${CMAKE_BINARY_DIR}/tests/auto
PRIVATE ${CMAKE_SOURCE_DIR}/src/KDMqtt ${CMAKE_SOURCE_DIR}/tests/auto/foundation/common
${CMAKE_BINARY_DIR}/tests/auto
)

target_link_libraries(
Expand Down
1 change: 1 addition & 0 deletions tests/auto/mqtt/tst_mqtt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <KDFoundation/core_application.h>
#include <KDMqtt/mqtt.h>
#include <memory>
#include "mosquitto_wrapper.h"

#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
#include <doctest/doctest.h>
Expand Down