Skip to content

Conversation

@marcothaller
Copy link
Contributor

We only use mosquitto types via pointers so we don't need full mosquitto headers to be included in our exported headers. This will make the life of users easier. We'll have only link time dependency.

@marcothaller marcothaller requested a review from MiKom April 9, 2025 18:50
We only use mosquitto types via pointers so we don't need full
mosquitto headers to be included in our exported headers. This will make
the life of users easier. We'll have only link time dependency.

Co-Authored-By: Marco Thaller <[email protected]>
Copy link
Member

@MiKom MiKom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake --install still seems to copy mosquitto_wrapper.h into $INSTALL_PREFIX/include/KDMqtt

You probably need to separate HEADERS variable in KDMqtt CMakeLists.txt file into public and private headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants