Add support for adding custom resources for jpackage #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebnuc
force-pushed
the
1972-add-support-for-jpackage-resources
branch
from
495d759 to
d6836d1
Compare
|
Just noticed there is #2266 already, but it's not as far developed as this I think. |
|
I think this needs more attention, who could we ping to have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to customize the WXS entries for packaging MSI files on Windows as described in #1972. I have added a solution here that works similar to the
appResourceRootDiroption:jpackageResourceRootDir. I'm not sure which resources can be added for Linux or macOS and am currently only aware of the customizations for Windows using Wix, however I presume there are things that can be customized for those operating systems as well.