Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot modify image assets used in MSI installer #2335

Closed
sebkur opened this issue Sep 21, 2022 · 5 comments
Closed

Cannot modify image assets used in MSI installer #2335

sebkur opened this issue Sep 21, 2022 · 5 comments

Comments

@sebkur
Copy link
Contributor

sebkur commented Sep 21, 2022

I'm successfully packaging MSI files using the Gradle plugin, however I cannot yet specify the images used in the MSI installer.

@sebnuc
Copy link

sebnuc commented Sep 21, 2022

These are screenshots from the MSI while installing it:

Screenshot 2022-09-21 125019
Screenshot 2022-09-21 125042

@sebnuc
Copy link

sebnuc commented Sep 21, 2022

This is what I'm trying to achieve, swap out the images on the left in the first screen and the banner at the top of the second screen:

Screenshot 2022-09-21 125500
Screenshot 2022-09-21 125517

@sebkur
Copy link
Contributor Author

sebkur commented Sep 21, 2022

As explained in the WIX documentation it is possible to set those images using these options in main.wxs, for example like this:

<?define JpResources = $(env.GRADLE_PROJECT_DIR)\src\jpackage\assets?>
<WixVariable Id="WixUIBannerBmp" Value="$(var.JpResources)\banner.bmp" />
<WixVariable Id="WixUIDialogBmp" Value="$(var.JpResources)\dialog.bmp" />

in order for this to work two things are necessary:

  1. we need to be able to add additional resources into the directory passed to jpackage with flag --resource-dir (Support for custom WXS entries during MSI packaging #1972)
  2. we need to have some way to define an environment variable that is accessible from thw WX toolchain process

@sebkur
Copy link
Contributor Author

sebkur commented Sep 21, 2022

I have a solution for 1.) ready here at: #2331 and a solution for 2.) at #2336.

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants