Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.9.0: bug fixes for fckit (disable finalization of DDTs) and ectrans (disable use of Fortran contiguous keyword) #518

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Feb 19, 2025

Description

All in the title.

Working towards JCSDA/spack-stack#1521
Working towards JCSDA/spack-stack#1522

See spack#49111 for the upstream PR for spack develop

For testing with spack-stack, see JCSDA/spack-stack#1523

…ake argument ECTRANS_HAVE_CONTIGUOUS_ISSUE to turn off problematic use of Fortran 'contiguous' keyword
…ake argument ENABLE_FINAL=OFF to turn off problematic finalization of derived data types
…ck/repos/builtin/packages/ectrans/package.py
@climbfuji climbfuji marked this pull request as ready for review February 19, 2025 14:56
Copy link

@fmahebert fmahebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks @climbfuji !

@climbfuji climbfuji merged commit 1c5e0ad into JCSDA:release/1.9.0 Feb 19, 2025
15 checks passed
@climbfuji climbfuji deleted the bugfix/rel190_fckit_ectrans branch February 19, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants