Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.9.0: bug fixes for fckit and ectrans, set BLA_VENDOR in eckit #1523

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Feb 19, 2025

Summary

This PR updates the submodule pointer for spack for the changes in:

Testing

Applications affected

JEDI

Systems affected

All systems with compilers that ectrans and fckit didn't handle correctly

Dependencies

Issue(s) addressed

Closes #1521
Closes #1522

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Feb 19, 2025
@fmahebert
Copy link
Contributor

Testing this now... will take a bit of time though, as you well know!

@climbfuji
Copy link
Collaborator Author

Testing this now... will take a bit of time though, as you well know!

Should I wait with merging the spack PR (not this spack-stack PR) until your testing is done?

@fmahebert
Copy link
Contributor

I should have results (one way or another) by end of day, so perhaps let's hold off on merging...

Copy link
Contributor

@fmahebert fmahebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my Ubuntu24 env with gcc13, I've built a new spack-stack from your fork and this branch. On this stack, jedi-bundle builds and ctests pass with no unexpected failures (one known failure remains).

Thus, I think we're good to proceed.

Thanks @climbfuji for the rapid iteration!

@climbfuji climbfuji enabled auto-merge (squash) February 19, 2025 23:26
@climbfuji climbfuji merged commit 4f026f7 into JCSDA:release/1.9.0 Feb 20, 2025
9 checks passed
@climbfuji climbfuji deleted the bugfix/rel190_fckit_ectrans branch February 20, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants