Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions network-mux/network-mux.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,30 @@ library
-Wredundant-constraints
-Wunused-packages

library traces
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
library traces
library trace-dispatcher-instances

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an option to make this a separate package for eg. cardano-network-mux-trace since network-mux in principle is a very general library. Another benefit is that in case we make changes to the tracers we will not have to make a release of network-mux. What's your take @coot ?

build-depends:
aeson,
base >=4.14 && <4.22,
formatting,
network-mux,
trace-dispatcher ^>= 2.10.0
hs-source-dirs: traces
visibility: public
exposed-modules:
Network.Mux.Traces
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a very similar module Network.Mux.Trace, what about Network.Mux.Trace.TraceDispatcher?

default-language: Haskell2010
default-extensions: ImportQualifiedPost
ghc-options:
-Wall
-Wcompat
-Widentities
-Wincomplete-record-updates
-Wincomplete-uni-patterns
-Wno-unticked-promoted-constructors
-Wpartial-fields
-Wredundant-constraints
-Wunused-packages

test-suite test
type: exitcode-stdio-1.0
hs-source-dirs: test
Expand Down
Loading