Fmaste/dmq node traces #5233
Fmaste/dmq node traces #5233
Conversation
A trace is emitted whenever a hot outbound peer is demoted or closed (possibly due to an error), giving the duration in seconds of how long the peer has been in hot mode. Added hot connection durations to peer selection debug state, which traces durations upon receiving sigusr1 interrupt.
…n-durations Trace connection durations
…n-durations restore tracking of hot connection durations when demoting a peer
ouroboros-network-0.22.1
Fixed quickcheck-monoids
ouroboros-network-0.22.2: bp defaults
Compatibility with QuickCheck-2.15
fmaste
force-pushed
the
fmaste/dmq-node-traces
branch
3 times, most recently
from
e1a6963 to
4aaeabe
Compare
fmaste
force-pushed
the
fmaste/dmq-node-traces
branch
from
4aaeabe to
817dbff
Compare
| hs-source-dirs: traces | ||
| visibility: public | ||
| exposed-modules: | ||
| Network.Mux.Traces |
There was a problem hiding this comment.
We already have a very similar module Network.Mux.Trace, what about Network.Mux.Trace.TraceDispatcher?
| -Wredundant-constraints | ||
| -Wunused-packages | ||
|
|
||
| library traces |
There was a problem hiding this comment.
| library traces | |
| library trace-dispatcher-instances |
| if flag(txsubmission-delay) | ||
| cpp-options: -DTXSUBMISSION_DELAY | ||
|
|
||
| library traces |
There was a problem hiding this comment.
| library traces | |
| library trace-dispatcher-instances |
| visibility: public | ||
| hs-source-dirs: traces | ||
| exposed-modules: | ||
| Ouroboros.Network.Traces |
There was a problem hiding this comment.
| Ouroboros.Network.Traces | |
| Ouroboros.Network.Trace.TraceDispatcher |
| -Wredundant-constraints | ||
| -Wno-unticked-promoted-constructors | ||
|
|
||
| library traces |
There was a problem hiding this comment.
In main, ouroboros-network-framework was integrated with ouroboros-network package, when you'll be rebasing, it might be a good idea to just put all the instances in a single package in ouroboros-network, even in a single module, since here there's just one orphan instance.
There was a problem hiding this comment.
Maybe better place is cardano-diffusion package?
| -Wredundant-constraints | ||
| -Wunused-packages | ||
|
|
||
| library traces |
There was a problem hiding this comment.
There's also an option to make this a separate package for eg. cardano-network-mux-trace since network-mux in principle is a very general library. Another benefit is that in case we make changes to the tracers we will not have to make a release of network-mux. What's your take @coot ?
| if flag(txsubmission-delay) | ||
| cpp-options: -DTXSUBMISSION_DELAY | ||
|
|
||
| library traces |
There was a problem hiding this comment.
Wouldn't cardano-diffusion be a better home for these instances?
| -Wredundant-constraints | ||
| -Wno-unticked-promoted-constructors | ||
|
|
||
| library traces |
There was a problem hiding this comment.
Maybe better place is cardano-diffusion package?
Description
reasonably detailed description of the pull request
Checklist
Quality
Maintenance
ouroboros-networkproject.