-
Notifications
You must be signed in to change notification settings - Fork 2
Update Content Type description and scope note #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
palemieux
wants to merge
1
commit into
master
Choose a base branch
from
palemieux-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| The Content Type is listed at **//ContentKind**:[^1] | ||
| The Content Type is listed at **//ContentKind**: | ||
|
|
||
| <CompositionPlaylist xmlns=”http://www.smpte-ra.org/schemas/429-7/2006/CPL”> | ||
| … | ||
| <ContentKind>feature</ContentKind> | ||
| … | ||
| <CompositionPlaylist> | ||
|
|
||
| [^1]: *If the scope attribute is absent, the permissible SMPTE 429-7 ContentKind values are as follows: “feature”, “trailer”, “teaser”, “test”, “rating”, “advertisement”, “short”, “transitional”, “psa”, and “policy”. If the scope attribute is present and set to `http://www.smpte–ra.org/schemas/429-16/2014/CPL-Metadata#scope/content-kind`, the permissible SMPTE ST 429-16 ContentKind values are as follows: “clip”, “promo” and “stereocard.” See the specification for details.* | ||
| +_NOTE_: As specified at SMPTE ST 429-7, 6.8, the `scope` attribute of the `ContentKind` element is present and set to the value specified in the _ContentKind Scope_ column of the register, _unless_ the _ContentKind Scope_ is equal to `http://www.smpte-ra.org/schemas/429-7/2006/CPL`, in which case the `scope` attribute can be omitted. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This address Adam's other point, and something that hadn't been addressed. We have to advise not to use the IMF based ContentKinds, as sorting in both TMS and servers don't have wide support for these values, and often get dropped to "unknown" or not listed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove them from the register then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are still usable as CTT fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are usable in CTT, then the bug is with the TMS and servers and no note is necessary.