-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update file restriction fields and tabular information to the file preview #234
Merged
ofahimIQSS
merged 5 commits into
develop
from
221-add-file-accessrestricted-and-permission-candownloadfile-check-to-filepreview
Jan 10, 2025
Merged
Update file restriction fields and tabular information to the file preview #234
ofahimIQSS
merged 5 commits into
develop
from
221-add-file-accessrestricted-and-permission-candownloadfile-check-to-filepreview
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
added
FY25 Sprint 14
FY25 Sprint 14 (2025-01-02 - 2025-01-15)
SPA: Collection Page
SPA.Q4.2
Collection Page: Extended item cards information
Size: 3
A percentage of a sprint. 2.1 hours.
Original size: 3
GREI Re-arch
GREI re-architecture-related
labels
Jan 3, 2025
jggautier
changed the title
Update file restriction fileds and tabular information to the file preview
Update file restriction fields and tabular information to the file preview
Jan 6, 2025
ekraffmiller
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had some suggestions for the CollectionRespository tests
ChengShi-1
added
Size: 10
A percentage of a sprint. 7 hours.
and removed
Size: 3
A percentage of a sprint. 2.1 hours.
labels
Jan 8, 2025
ekraffmiller
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved!
Visually inspected code, tests are passing. Merging PR |
ofahimIQSS
deleted the
221-add-file-accessrestricted-and-permission-candownloadfile-check-to-filepreview
branch
January 10, 2025 18:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 14
FY25 Sprint 14 (2025-01-02 - 2025-01-15)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 10
A percentage of a sprint. 7 hours.
SPA: Collection Page
SPA.Q4.2
Collection Page: Extended item cards information
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In collection page, some missing information is needed for every card item, including the lock icon, tags(categories), and tabular data info, so we need update in FilePreview model.
New fields include:
In datasetPreview, new field added
image_url: string
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Run all testcases and visually inspect
Is there a release notes update needed for this change?:
Additional documentation: