Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file tags, tabular variables, and observation into the item card information #578

Conversation

ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Jan 9, 2025

What this PR does / why we need it:

For Q4.2, the goal is to complete the missing information on the cards in collection page. Thus, this issues aims to implementing following missing info.

  • file tags

For tabular files,

  • variables
  • observations
  • tabular tags

Which issue(s) this PR closes:

Special notes for your reviewer:

changes variablesCount, observationsCount to variable, observation to keep name constant
wait for the IQSS/dataverse-client-javascript#234 to be merged, then the package.json should be removed

Suggestions on how to test this:

npm install and npm run build to update packages

  1. Go to SPA, create a dataset
  2. upload a .tab type file or other tabular types of data such as excel, csv etc.
  3. Go to JSF, locate the file just uploaded
  4. Click "ADD + Edit Metadata" button
  5. edit option => tags
    image
  6. gives some random tags(both file tags and tabular data tags) to the file, save changes
    image
  7. publish the dataset
  8. back to SPA, check if the variables, observations, and tags are shown correctly on collection page in SPA
    Also, check if File tags are in grey color while tabular data tags are in blue color

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

  • variables
  • observations
  • tags

image

@coveralls
Copy link

coveralls commented Jan 9, 2025

Coverage Status

coverage: 97.266% (+0.09%) from 97.179%
when pulling f72c2c0 on 564-collection-page-add-file-tags-into-the-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
into f758ee6 on develop.

@ChengShi-1 ChengShi-1 added GREI Re-arch GREI re-architecture-related Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page Original size: 3 SPA.Q4.2 Collection Page: Extended item cards information FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) labels Jan 9, 2025
@ChengShi-1 ChengShi-1 marked this pull request as ready for review January 11, 2025 19:43
@g-saracca g-saracca assigned g-saracca and unassigned g-saracca Jan 14, 2025
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
…e-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
…e-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
@ekraffmiller ekraffmiller self-assigned this Jan 21, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works great! Just a minor comment about spacing in the info card

Co-authored-by: Ellen Kraffmiller <[email protected]>
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

@ofahimIQSS
Copy link
Contributor

PR looks good. No issues found during testing. Merging
image

@ofahimIQSS ofahimIQSS merged commit dcdb033 into develop Jan 22, 2025
10 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the 564-collection-page-add-file-tags-into-the-item-card-information-and-add-numbers-tabular-tags-for-tabular-file branch January 22, 2025 18:41
@ofahimIQSS ofahimIQSS removed their assignment Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q4.2 Collection Page: Extended item cards information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection page: add file tags into the item card information, and add numbers & tabular tags for tabular file
6 participants