-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file tags, tabular variables, and observation into the item card information #578
Merged
ofahimIQSS
merged 9 commits into
develop
from
564-collection-page-add-file-tags-into-the-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
Jan 22, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
ChengShi-1
added
GREI Re-arch
GREI re-architecture-related
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Collection Page
Original size: 3
SPA.Q4.2
Collection Page: Extended item cards information
FY25 Sprint 14
FY25 Sprint 14 (2025-01-02 - 2025-01-15)
labels
Jan 9, 2025
…e-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
…e-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works great! Just a minor comment about spacing in the info card
src/sections/collection/collection-items-panel/items-list/file-card/FileCardInfo.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ellen Kraffmiller <[email protected]>
ekraffmiller
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved!
ofahimIQSS
deleted the
564-collection-page-add-file-tags-into-the-item-card-information-and-add-numbers-tabular-tags-for-tabular-file
branch
January 22, 2025 18:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 14
FY25 Sprint 14 (2025-01-02 - 2025-01-15)
FY25 Sprint 15
FY25 Sprint 15 (2025-01-15 - 2025-01-29)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Collection Page
SPA.Q4.2
Collection Page: Extended item cards information
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For Q4.2, the goal is to complete the missing information on the cards in collection page. Thus, this issues aims to implementing following missing info.
For tabular files,
Which issue(s) this PR closes:
Special notes for your reviewer:
changes
variablesCount, observationsCount
tovariable, observation
to keep name constantwait for the IQSS/dataverse-client-javascript#234 to be merged, then the package.json should be removed
Suggestions on how to test this:
npm install
andnpm run build
to update packages.tab
type file or other tabular types of data such as excel, csv etc.Also, check if File tags are in grey color while tabular data tags are in blue color
Does this PR introduce a user interface change? If mockups are available, please link/include them here: