Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement use case for sending information to contacts #232

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

implement use case for sending information to contacts #232

wants to merge 10 commits into from

Conversation

ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Dec 17, 2024 •
edited
Loading

What this PR does / why we need it:

Implement the use case allowing users to send feedback to contacts of collection or dataset.

The use case should:

  • send the information contacts
  • receive back from the api with details as well

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

  • The contact function exists in both collection & dataset, so I create the folder outside of collection though we aim to implementing "Contact" button for collection for Q4 now.
  • It allows the users that didn't log in to send information as well, so no permission restriction applies.

Suggestions on how to test this:

visually inspect and run tests on it

Is there a release notes update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.9 Collection Page: Contact FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) labels Dec 17, 2024
@ChengShi-1 ChengShi-1 linked an issue Dec 17, 2024 that may be closed by this pull request
Implement use case for sending information to contacts #231
Open
@cmbz cmbz mentioned this pull request Dec 19, 2024
Open
@GPortas GPortas self-assigned this Dec 20, 2024
GPortas
GPortas requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design, layering, and approach are correct, but we should use a different API endpoint for the reasons I mentioned in one of my comments. If there isn't an alternative endpoint in the API, we will need to implement one.

docs/useCases.md Show resolved Hide resolved
src/contactInfo/domain/useCases/SubmitContactInfo.ts Outdated Show resolved Hide resolved
src/contactInfo/domain/useCases/SubmitContactInfo.ts Outdated Show resolved Hide resolved
src/contactInfo/domain/useCases/SubmitContactInfo.ts Outdated Show resolved Hide resolved
src/contactInfo/infra/repositories/ContactRepository.ts Outdated Show resolved Hide resolved
test/integration/contact/ContactRepository.test.ts Outdated Show resolved Hide resolved
test/unit/contact/SubmitContactInfo.test.ts Outdated Show resolved Hide resolved
@GPortas GPortas assigned ChengShi-1 and unassigned GPortas Dec 20, 2024
@ChengShi-1 ChengShi-1 mentioned this pull request Jan 2, 2025
Closed
@cmbz cmbz added the FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) label Jan 2, 2025
@GPortas GPortas added the SPA.Q1 Not related to any specific Q1 feature label Jan 15, 2025
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
@cmbz cmbz added the FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) label Jan 30, 2025
@ChengShi-1 ChengShi-1 removed their assignment Feb 1, 2025
@ChengShi-1 ChengShi-1 removed the Waiting label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPortas GPortas GPortas requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1 Not related to any specific Q1 feature SPA.Q4.9 Collection Page: Contact
Projects
IQSS Dataverse Project
Status: Ready for Review ⏩
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement use case for sending information to contacts
4 participants
@ChengShi-1 @GPortas @cmbz @jp-tosca