Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Contact(sending feedback to contacts) API endpoint #11129

Closed
ChengShi-1 opened this issue Jan 2, 2025 · 3 comments · Fixed by #11162
Closed

Feature Request: Contact(sending feedback to contacts) API endpoint #11129

ChengShi-1 opened this issue Jan 2, 2025 · 3 comments · Fixed by #11162
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q1 Not related to any specific Q1 feature SPA.Q4.9 Collection Page: Contact Type: Feature a feature request
Milestone

Comments

@ChengShi-1
Copy link

Overview of the Feature Request
In SPA, users are allowed to send feedback to contacts of a collection, dataset or file.
Input would include subject, message, from (email autocomplete if login, or filled out by guest users).

In Native API, it has a similar API endpoint sending feedback to contact, but it is under admin path, and it returns contacts' email that could be sensitive. Send Feedback To Contact(s)

What kind of user is the feature intended for?
API User and all SPA users

What inspired the request?
SPA Q4.9
IQSS/dataverse-client-javascript#232

@ChengShi-1 ChengShi-1 added Type: Feature a feature request Size: 10 A percentage of a sprint. 7 hours. GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 SPA.Q4.9 Collection Page: Contact labels Jan 2, 2025
@ChengShi-1 ChengShi-1 moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Jan 8, 2025
@stevenwinship stevenwinship self-assigned this Jan 10, 2025
@stevenwinship stevenwinship moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Jan 10, 2025
@stevenwinship
Copy link
Contributor

@ChengShi-1 @pdurbin @qqmyers
Please comment on the following warning about email spam from the current FeedbackApi:

/**
* This method mimics the contact form and sends an email to the contacts of the
* specified Collection/Dataset/DataFile, optionally ccing the support email
* address, or to the support email address when there is no target object.
*
* !!!!! This should not be moved outside the /admin path unless/until some form
* of captcha or other spam-prevention mechanism is added. As is, it allows an
* unauthenticated user (with access to the /admin api path) to send email from
* anyone to any contacts in Dataverse. (It also does not do much to validate
* user input (e.g. to strip potentially malicious html, etc.)!!!!
**/

@GPortas GPortas added the SPA.Q1 Not related to any specific Q1 feature label Jan 15, 2025
@cmbz cmbz added the FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) label Jan 15, 2025
@pdurbin
Copy link
Member

pdurbin commented Jan 15, 2025

The comment was added by @qqmyers in #9186 and looks accurate to me.

I added the submitFeedback method itself in #4571 along with API tests that call into it. The method was only meant for testing, for making assertions about the behavior of the app.

@stevenwinship stevenwinship added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) and removed Size: 10 A percentage of a sprint. 7 hours. labels Jan 15, 2025
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
@stevenwinship stevenwinship removed their assignment Jan 16, 2025
@pdurbin
Copy link
Member

pdurbin commented Jan 31, 2025

Closed by merging this PR:

@pdurbin pdurbin closed this as completed Jan 31, 2025
@pdurbin pdurbin added this to the 6.6 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA.Q1 Not related to any specific Q1 feature SPA.Q4.9 Collection Page: Contact Type: Feature a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants