Skip to content

feat(theming): migrate from nc_theming to apps/theming IonosTheme #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanyaka merged 1 commit into from
Sep 2, 2026
Merged

feat(theming): migrate from nc_theming to apps/theming IonosTheme #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,11 @@ CUSTOM_COMPOSER_APPS = nc_ionos_processes
EXTERNAL_FULL_APPS = richdocuments user_oidc viewer
# Apps with special build targets (not in the standard categories above)
# These apps have dedicated build_<app>_app targets with custom build logic
SPECIAL_BUILD_APPS = nc_theming notify_push
SPECIAL_BUILD_APPS = notify_push

# Metadata for generate_apps_matrix_json: "name|path|has_npm|has_composer"
# One entry per app in SPECIAL_BUILD_APPS — must be kept in sync.
SPECIAL_BUILD_APPS_META = \
"nc_theming|apps-custom/nc_theming|false|true" \
"notify_push|apps-external/notify_push|false|true"

# App folders to add to shipped.json (makes apps non-removable)
Expand Down Expand Up @@ -181,12 +180,6 @@ $(EXTERNAL_FULL_TARGETS): build_%_app:

# Special build targets — custom logic that doesn't fit the standard categories

build_nc_theming_app: ## Build the custom css
@echo "[i] Building nc_theming app..."
cd apps-custom/nc_theming && \
$(MAKE) build_css
@echo "[✓] nc_theming app built successfully"

# notify_push binary target: downloads the pre-built binary from GitHub releases
$(NOTIFY_PUSH_BINARY): $(NOTIFY_PUSH_DIR)/appinfo/info.xml
@echo "[i] Building notify_push binary target for version $(NOTIFY_PUSH_VERSION)..."
Expand Down
2 changes: 1 addition & 1 deletion configs/enable-theme.config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
*/

$CONFIG = [
'theme' => 'nc-ionos-theme',
'enforce_theme' => 'ionos',
];
4 changes: 2 additions & 2 deletions configure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ SCRIPT_DIR="$(dirname "${0}")"
readonly SCRIPT_DIR
NEXTCLOUD_DIR="${SCRIPT_DIR}/.."
readonly NEXTCLOUD_DIR
FAVICON_DIR="$(cd "${NEXTCLOUD_DIR}/apps-custom/nc_theming/img" && pwd)"
FAVICON_DIR="$(cd "${NEXTCLOUD_DIR}/apps/theming/img" && pwd)"
readonly FAVICON_DIR
Comment thread
tanyaka marked this conversation as resolved.
readonly ADMIN_USERNAME=${ADMIN_USERNAME:-admin}
readonly ADMIN_EMAIL=${ADMIN_EMAIL:-admin@example.net}
Expand Down Expand Up @@ -200,7 +200,7 @@ config_ui() {
log_info "Configure theming"

execute_occ_command theming:config name "HiDrive Next"
execute_occ_command theming:config slogan "powered by IONOS"
execute_occ_command theming:config slogan ""
execute_occ_command theming:config imprintUrl " "
execute_occ_command theming:config privacyUrl " "
execute_occ_command theming:config primary_color "#003D8F"
Expand Down
Loading