feat(theming): migrate from nc_theming to apps/theming IonosTheme - #151
Merged
Conversation
18 tasks
…sTheme - enforce_theme: replace legacy 'nc-ionos-theme' with 'ionos' (ThemesService key) - configure.sh: update FAVICON_DIR to apps/theming/img (was apps-custom/nc_theming/img) - Makefile: remove nc_theming SPECIAL_BUILD_APP and build_nc_theming_app target Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de> Assisted-by: ClaudeCode:claude-sonnet-4-6
tanyaka
force-pushed
the
ionos-dev-v33-enhanced-theming
branch
2 times, most recently
from
August 27, 2026 13:04
1032608 to
802a9e1
Compare
There was a problem hiding this comment.
Pull request overview
Migrates IONOS theming integration away from the legacy nc_theming / nc-ionos-theme approach toward the consolidated apps/theming IonosTheme setup, aligning build/config tooling with the new theme registration model.
Changes:
- Updates shipped Nextcloud config to enforce the
ionostheme viaenforce_theme. - Adjusts
configure.shtheming setup: favicon source directory and clears the slogan. - Simplifies the build by removing
nc_themingfrom special-build handling in theMakefile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Makefile |
Removes nc_theming from SPECIAL_BUILD_APPS and deletes its custom build target. |
configure.sh |
Points favicon lookup at apps/theming/img and clears the theming slogan value. |
configs/enable-theme.config.php |
Switches from legacy theme to enforce_theme with key ionos. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Arsalanulhaq
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configs/enable-theme.config.php: Switch from legacy'theme' => 'nc-ionos-theme'(OC_Theme) to'enforce_theme' => 'ionos'(ThemesService key), matching the newIonosThemeclass inapps/themingconfigure.sh: UpdateFAVICON_DIRfromapps-custom/nc_theming/img→apps/theming/img; clear slogan (was"powered by IONOS"— footer content is now provided by CSS inapps/theming/css/ionos/guest.css)Makefile: Removenc_themingfromSPECIAL_BUILD_APPSand drop thebuild_nc_theming_apptarget — CSS is now static, no build step neededContext
Part of the enhanced theming consolidation: IONOS theming moves from two git submodules (
apps-custom/nc_themingandthemes/nc-ionos-theme) into the coreapps/themingapp, mirroring the ncw-server architecture. The companion PR in nc-server addsIonosTheme.phptoapps/theming/lib/Themes/and registers it inThemesService.AI Disclosure
This PR was created with assistance from Claude Code (claude-sonnet-4-6). All changes have been reviewed and tested manually.