Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moneymoney 2.4.48 url #197938

Closed
wants to merge 1 commit into from
Closed

moneymoney 2.4.48 url #197938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Casks/m/moneymoney.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version "2.4.48"
sha256 :no_check

url "https://service.moneymoney-app.com/1/MoneyMoney.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous url is the one provided by the vendor's sparkle feed, which is used by livecheck. I think it is ok to leave the existing method, as it aligns more closer with the updates, unless there is a specific reason that the pkg works better as an installer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The livecheck doesn't seem to be working as running 'brew livecheck moneymoney' brings up usage instructions for livecheck. I hadn't checked this before submitting the PR. Could I try to work on that as well and submit another PR later (and maybe close this one)? I'll keep the old url if I can figure out the livecheck block with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The livecheck is working fine on my end. Note that it is a developer command, so it won't work unless you have Homebrew setup as a developer.

Copy link
Contributor Author

@rlpvin rlpvin Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem to work with other casks, but it's probably something wrong on my end. Thank you for checking it out though. I don't think there's any reason why the pkg works better than the zip then, so I'm guessing this PR wasn't really needed. Apologies for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to apologise!
Thank you for contributing

url "https://moneymoney-app.com/download/MoneyMoney.pkg"
name "MoneyMoney"
desc "German banking and financial management software"
homepage "https://moneymoney-app.com/"
Expand All @@ -15,7 +15,9 @@
auto_updates true
depends_on macos: ">= :high_sierra"

app "MoneyMoney.app"
pkg "MoneyMoney.pkg"

uninstall pkgutil: "com.moneymoney-app.retail"

zap trash: [
"~/Library/Application Scripts/com.moneymoney-app.retail",
Expand Down
Loading