moneymoney 2.4.48 url #197938
moneymoney 2.4.48 url #197938
Conversation
| @@ -2,7 +2,7 @@ | |||
| version "2.4.48" | |||
| sha256 :no_check | |||
|
|
|||
| url "https://service.moneymoney-app.com/1/MoneyMoney.zip" | |||
There was a problem hiding this comment.
The previous url is the one provided by the vendor's sparkle feed, which is used by livecheck. I think it is ok to leave the existing method, as it aligns more closer with the updates, unless there is a specific reason that the pkg works better as an installer.
There was a problem hiding this comment.
The livecheck doesn't seem to be working as running 'brew livecheck moneymoney' brings up usage instructions for livecheck. I hadn't checked this before submitting the PR. Could I try to work on that as well and submit another PR later (and maybe close this one)? I'll keep the old url if I can figure out the livecheck block with it.
There was a problem hiding this comment.
The livecheck is working fine on my end. Note that it is a developer command, so it won't work unless you have Homebrew setup as a developer.
There was a problem hiding this comment.
It does seem to work with other casks, but it's probably something wrong on my end. Thank you for checking it out though. I don't think there's any reason why the pkg works better than the zip then, so I'm guessing this PR wasn't really needed. Apologies for that.
There was a problem hiding this comment.
No need to apologise!
Thank you for contributing
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Related to: #172732 (comment)