Deku Butler animation fix #1442
Conversation
mckinlee
left a comment
mckinlee
left a comment
There was a problem hiding this comment.
So glad you're back! Got some change requests for ya if you will.
|
aight, switching to a draft while I figure out if I rebased correctly |
|
everything should be ok now |
mckinlee
left a comment
mckinlee
left a comment
There was a problem hiding this comment.
Awesome! It does look like some changes to the libultraship submodule came through when you rebased though.. I also have a few other suggestions. I'm curious what everyone might think on the name change in particular. Other than that, this is looking good.
| // - `this->animIndex == EN_DNO_ANIM_SHOCK_LOOP` (bool) | ||
| VB_DEKU_BUTLER_FIX_SHOCK_ANIM, |
There was a problem hiding this comment.
I was thinking the name should be a bit more descriptive of what the vanilla behavior is. It also might be a good idea to make the comments regarding args more specific. This also needs to be moved since its not in alphabetical order.
| // - `this->animIndex == EN_DNO_ANIM_SHOCK_LOOP` (bool) | |
| VB_DEKU_BUTLER_FIX_SHOCK_ANIM, | |
| // - `*EnDno` (this) | |
| // - `*u8` (changeAnim) | |
| VB_DEKU_BUTLER_CHANGE_SHOCK_ANIMATION, |
|
I'm curious why there's a LUS commit change in here. The commit hashes are different, but the contents are identical. Was that intentional? |
3 participants
Fixes the deku butler's animation that loops incorrectly in the cutscene that plays when you free the deku princess.
Broken animation:
dekuButlerBrokenfocus.mp4
Fixed:
dekuButler.mp4
Build Artifacts