-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Referee during free kicks #1571
Draft
ThagonDuarte
wants to merge
16
commits into
HULKs:main
Choose a base branch
from
ThagonDuarte:visual-referee-2025-rule-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Visual Referee during free kicks #1571
ThagonDuarte
wants to merge
16
commits into
HULKs:main
from
ThagonDuarte:visual-referee-2025-rule-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThagonDuarte
added
the
rules:2025
Changes needed to comply to rule changes for the SPL 2025 Season.
label
Jan 11, 2025
ThagonDuarte
changed the title
Determine
Visual Referee during free kicks
Jan 11, 2025
kicking_team
during free kick set plays
ThagonDuarte
force-pushed
the
visual-referee-2025-rule-update
branch
3 times, most recently
from
January 12, 2025 12:03
3822b94
to
cc47d34
Compare
Co-authored-by: MaikRe <[email protected]>
Co-authored-by: MaikRe <[email protected]>
Co-authored-by: MaikRe <[email protected]>
Co-authored-by: MaikRe <[email protected]>
ThagonDuarte
force-pushed
the
visual-referee-2025-rule-update
branch
from
January 14, 2025 09:07
cc47d34
to
34d4a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
The rule update for the 2025 season introduces a change to the set play of free kicks. Instead of sending the kicking team in the game controller message during all free kicks, now, during
CornerKick
,GoalKick
,KickIn
, andPushingFreeKick
no kicking team will be sent in the game controller message. Instead, the head referee will give a visual signal to indicate the direction of play for the kicking team. This means a signal in the direction of the goal of the HULKs indicates that the Opponent is the kicking team. This signal can be seen below:This expands our current visual referee implementation to now also detect this free kick visual referee signal.
We only try to detect the visual referee signal in
KickIn
andPushingFreeKick
, since thekicking_team
duringCornerKick
andGoalKick
can be deduced from the current ball position and the teamsGlobalFieldSide
, i.e. whether their are home or away. DuringKickIn
andPushingFreeKick
, whenHome
theDefenderRight
andMidfielderRight
should look at the referee and do the detection. WhenAway
, this is done byDefenderLeft
andMidfielderLeft
.Fixes #1476
ToDo / Known Issues
kicking_team
kicking_team
and propagate to other Naos.kicking_team
to directly compute it in theSubState
sCornerKick
andGoalKick
.Action
s whilekicking_team
is not known yet (isNone
), i.e. that no NAO directly walks to the ball and tries to kick it.None
askicking_team
is handled correctlyKickingTeamFilter
works as intendedIdeas for Next Iterations (Not This PR)
kicking_team
directly by looking at thePenalty
set in the sameGameControllerMessage
as the transition to theSubState
PushingFreeKick
.team_ball
inKickingTeamFilter
. Depends on Striker transition from ball search to normal role assignment is riddich broken #1412How to Test
CornerKick
,GoalKick
,KickIn
, andPushingFreeKick
.KickIn
andPushingFreeKick
the only the correct defender and midfielder look at the referee and do the visual signal detection.GoalKick
andCornerKick
the correctkicking_team
is produced byKickingTeamFilter
and is correctly propagated to all nodes readykicking_team
.kicking_team
is propagated correctly to all nodes importingkicking_team
.Please also test where behavior had to be adapted to not knowing the
kicking_team
some of the time: