-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pepsi Maxi 🥤 #1486
base: main
Are you sure you want to change the base?
Pepsi Maxi 🥤 #1486
Conversation
129b02c
to
4c356bb
Compare
8486f75
to
a3db57f
Compare
aad668b
to
7548b59
Compare
let data_home = get_data_home().wrap_err("failed to get data home")?; | ||
let environment_file = &data_home.join(format!( | ||
"sdk/{version}/environment-setup-corei7-64-aldebaran-linux" | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes kaputt when building remotely. We have to use the data home on the remote which we'd either need to retrieve first or use shell magic to implement the logic from get_data_home
right inside the command we're building here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uff... What way do you suggest to fix that?
Why? What?
I'm excited to announce Pepsi Max, the effervescently revamped version of our command line tool that works hand in hand with the mighty "hulk" robotics framework. While the original Pepsi version had all the right ingredients, this rework brings them together with modern flair and clarity—without adding any extra calories, of course!
Here's what's bubbling up in Pepsi Max:
No More Recompiles for Config Changes: I’ve ditched the hard-coded constants in favor of a
hulk.toml
configuration file. Now, adjusting settings like the OS_VERSION of NAO is as easy as opening a can, with no need for recompiling or re-releasing a new version of Pepsi. Just pop, fizz, and go!Standardized Directory Locations: All SDKs and necessary artifacts are now following best practices and residing in XDG data directories, leaving behind the outdated hard-coded user home locations. Think of it as tidying up the fridge for maximum refreshment!
Repository Crate Overhaul: Say goodbye to the spaghetti code! The
repository
crate has undergone a major cleanup, moving to a module structure with well-documented code. This creates a solid, general-purpose library for interacting with the hulk repository—now that's refreshing!Dynamic Repository Root Detection: The search for the repository root is now done dynamically at runtime. I’m looking for a directory with a
hulk.toml
or using theHULK_DEFAULT_ROOT
environment variable. This means running Pepsi is now as spontaneous as reaching for your favorite soft drink.Pepsi Max is like opening a fizzing can of productivity with the sleekness of modern coding practices. By aligning this tool with current standards, I've made it easier to read, maintain, and enjoy—just like a thirst-quenching beverage should be.
Looking forward to your thoughts and feedback on this fizzy new take. I hope Pepsi Max will truly refresh your development experience and keep your workflow bubbling!
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
--continue-at -.
**/{manifest}/Cargo.toml
instead of manually defined aliases for manifestscodegen-units
How to Test
Extensive use of pepsi... Nearly every command was touched :(