Upload source distribution #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
added
is:Blocked
oleflb
added
tools:Tooling
julianschuler
force-pushed
the
upload-source
branch
from
c8b843a to
792933d
Compare
|
Is this finished? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
This PR adds also uploading the source code when uploading to a NAO to allow for reproducible build of e.g. the replayer at a later stage.
Blocked on #1486.
ToDo / Known Issues
None.
Ideas for Next Iterations (Not This PR)
Currently the whole repository except the
webotsfolder is uploaded. We should consider whether we want to exclude other subfolders like e.g.tools.How to Test
Upload to a NAO, connect to it and observe the source code in the
hulk/sourcesubfolder.