Skip to content

fix: UI sample_size ignored due to Planner LLM default override #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoonYong-Park wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: UI sample_size ignored due to Planner LLM default override #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions apps/backend/services/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
from datetime import datetime
from typing import Any, Dict, List, Optional

import yaml

from sqlalchemy.orm import Session

from ...core.credential_service import CredentialService, StoredCredential
Expand Down Expand Up @@ -68,6 +70,9 @@ def generate_leaderboard(self, query: LeaderboardQuery, user_id: Optional[int] =
plan_metadata = self.planner_agent.create_evaluation_plan(
query.query, secure_models
)
plan_metadata = self._apply_user_sample_size(
plan_metadata, query.sample_size
)
plan_metadata = self._attach_credential_references(
plan_metadata,
stored_credentials
Expand Down Expand Up @@ -408,6 +413,26 @@ def get_leaderboard_by_criteria(
total_models=len(leaderboard_entries)
)

@staticmethod
def _apply_user_sample_size(
plan_metadata: Dict[str, Any], sample_size: int
) -> Dict[str, Any]:
if plan_metadata.get("config"):
plan_metadata["config"]["sample_size"] = sample_size

plan_yaml_raw = plan_metadata.get("plan_yaml", "")
if plan_yaml_raw:
plan_dict = yaml.safe_load(plan_yaml_raw)
if plan_dict.get("metadata"):
plan_dict["metadata"]["sample_size"] = sample_size
for ds in plan_dict.get("datasets", []):
ds["sample_size"] = sample_size
plan_metadata["plan_yaml"] = yaml.dump(
plan_dict, default_flow_style=False, allow_unicode=True
)

return plan_metadata

def _default_plan_config(self) -> PlanConfig:
"""Create a safe default plan configuration."""
return PlanConfig(
Expand Down