fix: UI sample_size ignored due to Planner LLM default override#29
Open
JoonYong-Park wants to merge 1 commit intomainfrom
Open
fix: UI sample_size ignored due to Planner LLM default override#29JoonYong-Park wants to merge 1 commit intomainfrom
JoonYong-Park wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample_sizein bothplan_metadata.configandplan_yamlwith the user's actual selection after receiving the planner responseRoot Cause
In
generate_leaderboard(), onlyquery.query(the text string) was passed toplanner_agent.create_evaluation_plan(). The user'squery.sample_size(derived from the UI's sample_scale setting) was never forwarded. Since the Planner LLM prompt defaults tosample_size: 100, the UI setting was silently ignored.Before / After
Before — Custom(10) set but 100 samples evaluated
After — Custom(7) set and 7 samples evaluated correctly